Skip to content

Fix: Update URL launch method to use Uri.parse #12518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2025
Merged

Fix: Update URL launch method to use Uri.parse #12518

merged 2 commits into from
Oct 7, 2025
+2 −4

Conversation

dixita0607
Copy link
Contributor

Refer this issue for full description #12410

Before:

  • Wasn't opening the website by clicking on the launch button. I don't have a screenshot of that as the app was not breaking but was just not opening the webpage. I could not find any error logs in the emulator logs (may be because I am new to this). Only thing I can verify is that this issue persist in macos and iPhone 14 emulator.

After:
Opened the website uccessfully
image

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

@dixita0607
Update URL launch method to use Uri.parse
6fe6236 
 - fixes flutter#12410
 - It wasn't working in iOS. Later I noticed it for macos app too
@dixita0607 dixita0607 requested review from sfshaza2 and a team as code owners October 6, 2025 12:37
@parlough
Copy link
Member

parlough commented Oct 6, 2025

/gcbrun

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Oct 6, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit 60a9d97):

https://flutter-docs-prod--pr12518-fix-update-url-launcher-exa-qk5wfz9i.web.app

parlough
parlough reviewed Oct 6, 2025
View reviewed changes
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for fixing this! The change looks good to me.

There's one minor diagnostic that's triggering after the change though:

@dixita0607
Copy link
Contributor Author

dixita0607 commented Oct 6, 2025 •
edited
Loading

I have fixed it now. I am sorry for wasting your time in this silly mistake. I got so excited to submit this PR that I forgot to test it before pushing a commit.

@parlough
Copy link
Member

parlough commented Oct 7, 2025

I have fixed it now. I am sorry for wasting your time in this silly mistake. I got so excited to submit this PR that I forgot to test it before pushing a commit.

Definitely not a silly mistake nor a waste of my time! I wouldn't have noticed either as imports are often used multiple times :)

I really appreciate you fixing this and making that extra adjustment :D

parlough
parlough approved these changes Oct 7, 2025
View reviewed changes
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks again :D

@parlough parlough merged commit 613860f into flutter:main Oct 7, 2025
9 checks passed
@dixita0607 dixita0607 deleted the fix/update-url-launcher-example branch October 7, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parlough parlough parlough approved these changes

@sfshaza2 sfshaza2 Awaiting requested review from sfshaza2 sfshaza2 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dixita0607 @parlough @flutter-website-bot